Android: Add online system update functionality #10369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Jan 13, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Outdated
Show resolved
Hide resolved
...a/org/dolphinemu/dolphinemu/features/sysupdate/ui/OnlineUpdateProgressBarDialogFragment.java
Outdated
Show resolved
Hide resolved
.../org/dolphinemu/dolphinemu/features/sysupdate/ui/OnlineUpdateRegionSelectDialogFragment.java
Outdated
Show resolved
Hide resolved
| public Dialog onCreateDialog(@Nullable Bundle savedInstanceState) | ||
| { | ||
| // Rotating the device while the update is running can result in a title failing to import. | ||
| getActivity().setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LOCKED); |
There was a problem hiding this comment.
This feels rather ugly in general. Is there really no better solution? (Not that I can think of what the better solution would be myself...)
There was a problem hiding this comment.
Unfortunately, the mitigation is the best thing I could come up with, I'm not sure why the update is stopping on rotation. :/
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/TvMainActivity.java
Outdated
Show resolved
Hide resolved
OatmealDome
requested changes
Jan 13, 2022
Simonx22
force-pushed
the
android-online-system-update-2
branch
4 times, most recently
from
c62cd20
to
b70d34d
Compare
|
So, what's up with FifoCI randomly triggering on PRs that don't touch any rendering related code lately? |
Simonx22
force-pushed
the
android-online-system-update-2
branch
from
b70d34d
to
676527e
Compare
|
@mbc07 I introduced a new FifoCI worker running on the M1 Mac because I thought it would be useful, but it appears to render odd one pixel differences every run. We're not sure why. |
JosJuice
reviewed
Jan 20, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/ContinueLaunchCallback.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/ContinueLaunchCallback.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/activities/EmulationActivity.java
Outdated
Show resolved
Hide resolved
...app/src/main/java/org/dolphinemu/dolphinemu/features/sysupdate/ui/SystemUpdateViewModel.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainPresenter.java
Outdated
Show resolved
Hide resolved
OatmealDome
force-pushed
the
android-online-system-update-2
branch
from
676527e
to
2360345
Compare
Simonx22
force-pushed
the
android-online-system-update-2
branch
from
2360345
to
6ba55b8
Compare
OatmealDome
force-pushed
the
android-online-system-update-2
branch
2 times, most recently
from
d37ca36
to
8c81ef8
Compare
OatmealDome
force-pushed
the
android-online-system-update-2
branch
from
8c81ef8
to
55378ca
Compare
|
I've addressed all comments. The progress bar is also no longer saying "NaN %" now. |
JosJuice
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the online system update functionality to the Android version of Dolphin.
Thanks to @OatmealDome for helping me to debug my issues and help me out on the C++ part.
There are two remaining issues:
setRequestedOrientation. The rotation will be unlocked after the update is done. A log file for this problem can be found here: https://gist.github.com/Simonx22/9dc0f0bd7650d600fbd62f273b4f5d2aScreenshots:
