Kill Core::g_CoreStartupParameter. #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be a reasonably safe change, assuming you caught them all. |
|
Looks good and finally. |
|
Please rebase and fix the instances in Source/Core/Core/PowerPC/Jit64/JitAsm.cpp. Thanks. |
|
🙌 |
RachelBryk
force-pushed
the
kill-g_CoreStartupParameter
branch
from
05355ac
to
f93aa70
Compare
|
Looks good to me. |
skidau
added a commit
that referenced
this pull request
Sep 10, 2014
Kill Core::g_CoreStartupParameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.