DolphinQt: Enable accuracy slider back after a custom value #10472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3t13nn3
changed the title
leoetlino
reviewed
Mar 2, 2022
| @@ -151,6 +151,9 @@ void HacksWidget::ConnectWidgets() | |||
|
|
|||
| void HacksWidget::LoadSettings() | |||
| { | |||
| // Need to enable the slider if it was turn off (in case of changes) | |||
There was a problem hiding this comment.
Suggested change
| // Need to enable the slider if it was turn off (in case of changes) | |
| // Re-enable the slider in case it was disabled because of a custom value |
It might also make sense to move this closer to the setEnabled(false) call (perhaps right before the switch statement?)
There was a problem hiding this comment.
I agree, it could me more clear.
|
Please also update the commit message so it includes the details that currently are available in the PR description only. |
|
-> #10573. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this issue https://bugs.dolphin-emu.org/issues/12771, using a custom value on a particular game for the texture cache makes the slider disable until we reboot the app.
Choosing a custom value disable the slider, but don't make it active again after we end the instance of the current game. Then it keep the game config and we couldn't change it.
This change is about enabling the slider if it is disable (due to a custom value for a game).