Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DolphinQt: Enable accuracy slider back after a custom value #10472

Closed
wants to merge 1 commit into from
Closed

DolphinQt: Enable accuracy slider back after a custom value #10472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ void HacksWidget::ConnectWidgets()

void HacksWidget::LoadSettings()
{
// Need to enable the slider if it was turn off (in case of changes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Need to enable the slider if it was turn off (in case of changes)
// Re-enable the slider in case it was disabled because of a custom value

It might also make sense to move this closer to the setEnabled(false) call (perhaps right before the switch statement?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it could me more clear.

m_accuracy->setEnabled(true);

const QSignalBlocker blocker(m_accuracy);
auto samples = Config::Get(Config::GFX_SAFE_TEXTURE_CACHE_COLOR_SAMPLES);

Expand Down