Reduce logspam at info level #10504
Merged
Reduce logspam at info level #10504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This message would be logged, usually multiple times, for EVERY. SINGLE. PIXEL. That's pretty much useless and just makes the log unreadable. Plus, the current support (which acts as RGB8) is close enough that for end-user purposes, it's fine. I don't think the hardware backends support RGB565_Z16 and its antialiasing functionality correctly either, but they don't have similar logspam.
These messages hid other, more important, ones often. I have left AttemptMaxTimesWithExponentialDelay and GetSysDirectory/SetSysDirectory as info, since those are called infrequently and can be useful to the end-user.
|
New logs:
Note that logs are stored compressed on the buildbot, so the amount of used storage is even smaller, and that the log I am referring to is shell_3 (gfx test). |
This was referenced Mar 9, 2022
|
LGTM. Many of the FileUtil COMMON logs were redundant with some logs (IOS FS and WFS) anyway. |
BhaaLseN
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After dolphin-emu/fifoci#47, fifoci now shows log messages at the info level. This greatly inflated the log sizes; however, as some spammy log messages are included.
pr-fifoci-ogl-lin-mesahas a 9 MB, 69091-line log, of which 63854 lines are related to various FileUtil operations. Andpr-fifoci-sw-lin-mesahas a 572 MB, 5128601-line log, of which 63345 lines were related to FileUtil, and 5060654 were related to the software renderer saying that the RGB565_Z16 pixel format isn't correctly supported multiple times for every single pixel drawn. (The hardware renderers also do not correctly support RGB565_Z16 at this time, but they don't have any such logging.)I've removed the RGB565_Z16 messages, and changed the FileUtil ones to be at the debug level (apart from a few messages that are possibly useful to users).