Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config-uberogl: Enable DumpFramesAsImages #48

Merged

Conversation

Pokechu22
Copy link
Contributor

This fixes the duplicated 3rd frame on fifoci-uberogl-lin-radeon, as it was generating an AVI file from which the frames were extracted, instead of dumping directly as PNGs.

Tested at dolphin-emu/dolphin#10505. I recommend merging this and then immediately afterwards merging dolphin-emu/dolphin#10504 so that the resulting fifoci differences are attributed to that PR (instead of whatever random unrelated PR is merged next).

This fixes the duplicated 3rd frame on fifoci-uberogl-lin-radeon, as it was generating an AVI file from which the frames were extracted, instead of dumping directly as PNGs.
@Pokechu22
Copy link
Contributor Author

Oh, I should also add: as JosJuice mentioned in dolphin-emu/dolphin#10505 (comment), #34 enabled DumpFramesAsImages for the other configurations. I added the ubershader configuration in #36, which came after that, so I should have based my configuration off of the one with DumpFramesAsImages enabled, but it seems like I didn't; I'm not sure what happened there. (There might have been a rebase that's not visible, or maybe I deleted the DumpFramesAsImages line for some reason?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants