Jit: Automatically clear cache when JIT settings are updated #10575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
3f056f2
to
7bb933a
Compare
lioncash
reviewed
Apr 11, 2022
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
7bb933a
to
2a0033a
Compare
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
2a0033a
to
97046f8
Compare
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
97046f8
to
f61bdf1
Compare
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
f61bdf1
to
e5f47c2
Compare
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
e5f47c2
to
04fb337
Compare
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
04fb337
to
aa84356
Compare
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
aa84356
to
0d62ecf
Compare
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
0d62ecf
to
36dd3ab
Compare
|
This seems fine to me but I'd feel safer with it in combination with #12117. |
This fixes a problem where changing the JIT debug settings on Android while a game was running wouldn't cause the changed settings to apply to code blocks that already had been compiled.
There's no reason not to allow this now that these settings are cleanly integrated into the new config system. (Actually, maybe we could even have done this before the previous commit...)
JosJuice
force-pushed
the
jitbase-auto-clear
branch
from
36dd3ab
to
85281e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where changing the JIT debug settings on Android while a game was running wouldn't cause the changed settings to apply to code blocks that already had been compiled.