Qt/CodeViewWidget: Replace the click-to-center behavior with a scrollbar. #10648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
code-view-scrollbar-etc
branch
2 times, most recently
from
0bc172f
to
65d4661
Compare
AdmiralCurtiss
force-pushed
the
code-view-scrollbar-etc
branch
from
65d4661
to
2739b55
Compare
AdmiralCurtiss
force-pushed
the
code-view-scrollbar-etc
branch
from
2739b55
to
0b71165
Compare
AdmiralCurtiss
force-pushed
the
code-view-scrollbar-etc
branch
from
0b71165
to
e488d7c
Compare
…table centers the table on that row. This also required a handful of other changes since now the non-center row can be the user-highlighted one.
AdmiralCurtiss
force-pushed
the
code-view-scrollbar-etc
branch
from
e488d7c
to
656b12f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #10612 but for the code widget. This one is a bit more awkward because the center row has a semantic meaning (it's the row the callers and callees are shown for), so this might need some more tweaking to feel correct...