Disable icache emulation for Monster House #10739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This game has stale icache values in the logs during certain loadscreens, and after disabling them I was able to play through the entire game, with one crash that may have been related to savestates and memory cards since during that loadscreen it said the memory card did not match. This does cause invalid reads to be spit out during parts of the game, but you can safely skip them. Enabling MMU seems to surpress the invalid reads without side-effects, but the aforementioned memcard/savestate crash was with MMU on.
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
JosJuice
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This game has stale icache values in the logs during certain loadscreens, and after disabling them I was able to play through the entire game, with one crash that may have been related to savestates and memory cards since during that loadscreen it said the memory card did not match.
This does cause invalid reads to be spit out during parts of the game, but you can safely skip them. Enabling MMU seems to surpress the invalid reads without side-effects, but the aforementioned memcard/savestate crash was with MMU on.
I did 100% complete the game with this set in order to verify that we can finally mark this annoying game as playable.