Require frontend to initialize controllers #10783
Conversation
|
I think nogui never deinitializes controllers so it now crashes on program termination because some parts of that are still running. At least I'm getting a failure in some |
|
Yeah, adding a call to |
JosJuice
force-pushed
the
frontend-controller-init
branch
from
daf8126
to
c5c09a5
Compare
|
I've marked this as a draft for now because of the FifoCI failures. Neither I or AdmiralCurtiss can reproduce the problem on Windows, so if there's someone who could try to reproduce this on Linux (maybe headless is needed?), that would be appreciated. Alternatively, if there's some way to get logs from FifoCI that I'm not aware of... |
|
FifoCI logs are at eg. https://dolphin.ci/#/builders/16/builds/7127/steps/7/logs/stdio but it doesn't really help here, it just says segmentation fault. |
We currently have two different code paths for initializing controllers: Either the frontend (DolphinQt) can do it, or if the frontend doesn't do it, the core will do it automatically when booting. Having these two paths has caused problems in the past due to only one frontend being tested (see de7ef47). I would like to get rid of the latter path to avoid further problems like this.
JosJuice
force-pushed
the
frontend-controller-init
branch
from
ac4f177
to
dabad82
Compare
|
FifoCI is no longer reporting any failures. Well, I'm not quite sure what happened, but since there seem to be no problems right now and I don't know of anything that's wrong in the code, I'll unmark this as a draft. |
|
Yeah I don't get it either, but it works and the code looks correct to me so shrug. |
|
Hi. Sorry to hijack this PR. However, I believe I have information that might be useful to you folks. This PR broke Dolphin on Android using Real WiiMotes and a DolphinBar. Steps to reproduce:
Dolphin will try to launch, but will crash immediately. Phone is a Galaxy S10 with Snapdragon CPU running Android 12. Logs here |
|
Thanks for quickly noticing and reporting this! Since you've already created a report on the issue tracker, let's continue the conversation there: https://bugs.dolphin-emu.org/issues/12980 |
We currently have two different code paths for initializing controllers: Either the frontend (DolphinQt) can do it, or if the frontend doesn't do it, the core will do it automatically when booting. Having these two paths has caused problems in the past due to only one frontend being tested (see PR #9086). I would like to get rid of the latter path to avoid further problems like this.