RegisterWidget: Fix crash when right-clicking when there is no selected cell #10800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, Dolphin would crash if you right-clicked in the blank space on the bottom-right, or if you right-clicked outside of the table without having first clicked on a register. Now, the context menu properly appears, with only "update" listed (I'm not entirely sure what that does, though).
Note that right-clicking outside of the table will use the currently selected register's context menu (instead of the update-only one); this behavior existed beforehand.
I also did a quick check of other uses of
customContextMenuRequested
, and they all seem to check that a selection exists (or else don't depend on having a selection at all), though I wasn't too deep in this checking (as long as it looked like anif
-statement existed, I decided it was probably good).