Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Graphics Mods Fixes #10801

Merged
merged 2 commits into from Jul 2, 2022
Merged

Conversation

iwubcode
Copy link
Contributor

@iwubcode iwubcode commented Jul 2, 2022

Some other minor fixes to graphics mods.

  1. The way the graphics mods UI works is it allows you to change your settings but only saves them when the window closes (to avoid additional disk writes). However, it was rather jarring when you hit "Reload" after making changes because it would revert to your previous save. Now if you click "Reload" (to see new graphics mods or to pickup new changes), it will save first..then reload.
  2. Add word wrap to the description. Long descriptions would cause the UI to spaz out. Now it works properly.

Before:

image

After:

image

@Pokechu22
Copy link
Contributor

Tested and "save changes to disk before refreshing mod list" and "add word wrap to graphics mods description" look good to me. (Perpaps SaveToDisk should be SaveToDiskIfDirty and do the check on m_needs_save itself, but that's not too important.)

I'm a bit confused about the last commit; if I remove a mod from the GraphicsMods folder (in either the Sys folder or the user folder), it temporarily disappears from the list, but if I return it later, then it reappears in the list and maintains its checked status. The existing behavior seems like correct behavior, but if that's not what changed, then what did that commit fix?

@iwubcode
Copy link
Contributor Author

iwubcode commented Jul 2, 2022

@Pokechu22 - thanks for questioning that (and for reviewing!). I did more testing and I did not see anything wrong with master's functionality. I can't recall what I was seeing. Anyway, I dropped the commit.

@JMC47 JMC47 merged commit edd89e3 into dolphin-emu:master Jul 2, 2022
@iwubcode iwubcode deleted the graphics_mod_fixes_part2 branch July 2, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants