Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Don't check for WSL2 host path on non-Linux OSes #10986

Merged
merged 1 commit into from Jan 5, 2023

Conversation

OatmealDome
Copy link
Member

The parameters used for the stat command are only valid when using GNU coreutils. On OSes that use BSD tools (for example, macOS), the command will fail and the script will exit.

@OatmealDome OatmealDome marked this pull request as ready for review August 15, 2022 20:17
@shuffle2
Copy link
Contributor

shuffle2 commented Aug 15, 2022

maybe it would be slightly better to (stat --version | grep GNU or smth) query the stat itself?

@AdmiralCurtiss
Copy link
Contributor

Since this is only supposed to ever be true on WSL (ie, it doesn't matter which of the two conditions fails on anything but WSL), I think this is fine as-is.

@AdmiralCurtiss AdmiralCurtiss merged commit 7cd3839 into dolphin-emu:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants