Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater: Move inflate intermediate buffer to heap and enlarge #11058

Merged
merged 1 commit into from Sep 20, 2022
Merged

Updater: Move inflate intermediate buffer to heap and enlarge #11058

merged 1 commit into from Sep 20, 2022

Conversation

shuffle2
Copy link
Contributor

No description provided.

@AdmiralCurtiss
Copy link
Contributor

Is there an advantage to having a larger buffer?

@shuffle2
Copy link
Contributor Author

shuffle2 commented Sep 18, 2022

Both changes are for speed: the buffer will now be properly aligned for simd, and zlib-ng can take advantage of that and the larger buffer size to use faster code.

@AdmiralCurtiss AdmiralCurtiss merged commit d04e1ca into dolphin-emu:master Sep 20, 2022
@dvessel
Copy link
Contributor

dvessel commented Sep 20, 2022

I’m getting this error after the change. All games on Metal, M1..

01:09:319 Common/Arm64Emitter.cpp:537 E[JIT]: Warning: An error occurred.

64-bit load/store must use aligned offset: 1892

  Condition: (imm & 0x7) == 0
  File: /Users/foo/Projects/mac/dolphin/Source/Core/Common/Arm64Emitter.cpp
  Line: 537
  Function: EncodeLoadStoreIndexedInst

Ignore and continue?

@dvessel
Copy link
Contributor

dvessel commented Sep 20, 2022

The changed files in here shouldn’t cause this bug but I tried running with #10808 (previous commit) and it runs fine. 10808 looks like it should be causing the bug. I’ll do more testing.

@shuffle2 shuffle2 deleted the updater-inflate branch October 21, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants