Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Allow mapping buttons to expand horizontally. #11271

Merged

Conversation

jordan-woyak
Copy link
Member

The removed hacks are no longer needed now that the base-class, ElidedButton, overrides sizeHint.

This fixes: https://bugs.dolphin-emu.org/issues/11707

image

@Miksel12
Copy link
Contributor

Looks great! This gives much more room for more complex mappings with multiple inputs/operators.

@MayImilae
Copy link
Contributor

MayImilae commented Nov 12, 2022

Looks good. However, I'm a little concerned that this will cause some issues with translations, as this is defining horizontal space more concretely. Specifically cases like "Dead Zone", where the English name is shorter than basically any other language. But I'm not really involved in that enough to properly advise on that front.

@Miksel12
Copy link
Contributor

I believe spacing is done dynamically so that shouldn't be a problem, I looked at the changes with the Dutch translation and I didn't see any alignment issues.

@MayImilae
Copy link
Contributor

MayImilae commented Nov 12, 2022

I'm not super familiar with our translations, but I can look at code. Looking at our Dutch translation, Dead Zone is currently translated to "Dead Zone". I don't think that counts as a valid comparison.

The worst case scenario I could fine is Arabic. "المنطقة الميتة" That is the one to test. Greek or Russian would be other ones to try.

@Miksel12
Copy link
Contributor

I checked again and alignment is done dynamically, so it is aligned to the longest word in each column for each translation.

Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like an improvement to me.

@AdmiralCurtiss AdmiralCurtiss merged commit f05b0ad into dolphin-emu:master Nov 14, 2022
@jordan-woyak jordan-woyak deleted the mapping-button-expanding branch November 15, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants