Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QGridLayout for mapping settings #9496

Conversation

DacodaDragon
Copy link
Contributor

Takes a wack at https://bugs.dolphin-emu.org/issues/11707#change-741102

Mapping button resizing grid

Picking at the low priority issues since I still lack experience doing more significant things.

I'm considering making a separate class that inherits from QGridLayout to support the "AddRow" functionality in QFormLayout.

@Miksel12
Copy link
Contributor

Miksel12 commented Feb 8, 2021

Looks great, I got stuck on the "Connect MotionPlus" widget. I assume that is the reason why you need to add "AddRow" functionality?

@DacodaDragon
Copy link
Contributor Author

DacodaDragon commented Feb 8, 2021

Looks great, I got stuck on the "Connect MotionPlus" widget. I assume that is the reason why you need to add "AddRow" functionality?

image

I'm currently tinkering around with this. It would be nice if it would somewhat follow the behavior of the other ones or stay aligned to the left entirely. I wouldn't know what expression to base the different alignment on.

@Dentomologist
Copy link
Contributor

I think a better approach would be to keep using the form layout but remove the maximum width on the buttons.

In addition to that being more consistent with most of the config buttons, your .gif shows that even max-width buttons can't fit input expressions longer than a certain length. While there will always be expressions too long to fit in a given width, we can at least let that be dictated by the window width/user's monitor rather than an arbitrary limit.

@jordan-woyak
Copy link
Member

The mentioned issue has instead been solved by PR #11271.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants