Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update min macos version to 10.15 #11361

Merged
merged 1 commit into from Jan 9, 2023
Merged

update min macos version to 10.15 #11361

merged 1 commit into from Jan 9, 2023

Conversation

shuffle2
Copy link
Contributor

This should be all that's required to make the Updater gracefully tell people on < 10.15 to update.

If we can go higher than 10.15, I'd love to know :)

This will unblock std::filesystem stuff

@MayImilae
Copy link
Contributor

The only change 10.15 does to our device coverage is that we would lose support for pre-trashcan Mac Pros that support Metal. Everything else is unchanged compared to 10.14. So this won't impact our userbase much. If this gives us something useful, then sure.

macOS 11 will take out a lot of devices though, including my 2012 MacBook Pro. That one we should hold off on for as long as we can.

@pizuz
Copy link

pizuz commented Dec 22, 2022

macOS 11 will take out a lot of devices though, including my 2012 MacBook Pro. That one we should hold off on for as long as we can.

There‘s always OCLP for that, but generally you‘re right. On the other hand, running an OS past the end of life isn‘t such a good idea, anyway…

@OatmealDome
Copy link
Member

Should probably update the README while we're at it. (Wiki + website also need to be updated, but can't do that with a PR.)

10.15 is about the limit of what I'm comfortable updating our minimum to. As far as I'm aware, there isn't anything that we can gain by going higher. Like MayImilae said, hardware support from 10.14 -> 10.15 is nearly identical and older Macs start dropping like flies starting with 11, so we should hold off on that.

@PEmu2
Copy link
Contributor

PEmu2 commented Dec 22, 2022

Should the deployment target in BuildMacOSUniversalBinary.py be updated as well?

https://github.com/dolphin-emu/dolphin/blob/master/BuildMacOSUniversalBinary.py#L67

(Wiki + website also need to be updated, but can't do that with a PR.)

The website FAQ needs to be updated regardless of this PR as it still lists High Sierra as supported. Would be great if these parts of the website were available to be edited on GitHub as it's pretty clear they're not getting much attention these days.

@shuffle2
Copy link
Contributor Author

This PR should now include the rest of the places where min macos version is mentioned in this repo.

Readme.md Outdated Show resolved Hide resolved
@shuffle2
Copy link
Contributor Author

next bikeshedding topic?

Copy link
Member

@OatmealDome OatmealDome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there might be a beta releasing around Christmas, perhaps we should merge this after that happens.

@shuffle2
Copy link
Contributor Author

There just was a beta (5.0-17995) which is why I made this PR now.

@OatmealDome
Copy link
Member

afaik JMC wants to push another beta to fix a bug in 5.0-17995 (see IRC). Something about the FPS counter colors being wrong with specific settings.

@shuffle2
Copy link
Contributor Author

that's fine? This PR was only waiting for the Updater changes to make it into a beta (which should now be the case, right?) So there is no reason to wait more.

@PEmu2
Copy link
Contributor

PEmu2 commented Dec 23, 2022

One thing that might be worth taking into account is that while Catalina runs on most of the same hardware as Mojave there are probably some users who haven't upgraded for the sake of preserving 32-bit app support. I don't have the Dolphin analytics numbers to know if that's actually a practical concern or not. As a rough approximation the Steam hardware and software survey currently has Mojave and earlier as roughly ~7% of the macOS user base.

@shuffle2
Copy link
Contributor Author

I think we've already had the discussion of "can we update to requiring 10.15" months ago and this doesn't need to be rehashed.

@shuffle2
Copy link
Contributor Author

shuffle2 commented Jan 3, 2023

hello?

dvessel added a commit to dvessel/dolphin that referenced this pull request Jan 6, 2023
@shuffle2
Copy link
Contributor Author

shuffle2 commented Jan 8, 2023

please merge this. literally begging at this point, super annoying.

Copy link
Member

@OatmealDome OatmealDome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to JMC, looks like the holiday beta was delayed.

@shuffle2
Copy link
Contributor Author

shuffle2 commented Jan 8, 2023

This has nothing to do with that, though :(

The Mac Updater became able to handle checking OS version in 089886a
The current beta is 8bad821 , which includes the above commit. Therefor, existing deployed builds of the beta are capable of handling this change gracefully (and would not be encountered until the next beta is released).
So, there is no reason to wait.

@JMC47 JMC47 merged commit e06c115 into dolphin-emu:master Jan 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants