update min macos version to 10.15 #11361
Conversation
|
The only change 10.15 does to our device coverage is that we would lose support for pre-trashcan Mac Pros that support Metal. Everything else is unchanged compared to 10.14. So this won't impact our userbase much. If this gives us something useful, then sure. macOS 11 will take out a lot of devices though, including my 2012 MacBook Pro. That one we should hold off on for as long as we can. |
There‘s always OCLP for that, but generally you‘re right. On the other hand, running an OS past the end of life isn‘t such a good idea, anyway… |
|
Should probably update the README while we're at it. (Wiki + website also need to be updated, but can't do that with a PR.) 10.15 is about the limit of what I'm comfortable updating our minimum to. As far as I'm aware, there isn't anything that we can gain by going higher. Like MayImilae said, hardware support from 10.14 -> 10.15 is nearly identical and older Macs start dropping like flies starting with 11, so we should hold off on that. |
|
Should the deployment target in BuildMacOSUniversalBinary.py be updated as well? https://github.com/dolphin-emu/dolphin/blob/master/BuildMacOSUniversalBinary.py#L67
The website FAQ needs to be updated regardless of this PR as it still lists High Sierra as supported. Would be great if these parts of the website were available to be edited on GitHub as it's pretty clear they're not getting much attention these days. |
|
This PR should now include the rest of the places where min macos version is mentioned in this repo. |
|
next bikeshedding topic? |
|
There just was a beta (5.0-17995) which is why I made this PR now. |
|
afaik JMC wants to push another beta to fix a bug in 5.0-17995 (see IRC). Something about the FPS counter colors being wrong with specific settings. |
|
that's fine? This PR was only waiting for the Updater changes to make it into a beta (which should now be the case, right?) So there is no reason to wait more. |
|
One thing that might be worth taking into account is that while Catalina runs on most of the same hardware as Mojave there are probably some users who haven't upgraded for the sake of preserving 32-bit app support. I don't have the Dolphin analytics numbers to know if that's actually a practical concern or not. As a rough approximation the Steam hardware and software survey currently has Mojave and earlier as roughly ~7% of the macOS user base. |
|
I think we've already had the discussion of "can we update to requiring 10.15" months ago and this doesn't need to be rehashed. |
|
hello? |
|
please merge this. literally begging at this point, super annoying. |
|
This has nothing to do with that, though :( The Mac Updater became able to handle checking OS version in 089886a |
|
I am now an angry user. |
|
I am angered by this, too. Not because I don't see the use of 10.15, but because it removes all 32-bit support– drivers which are essential for playing a great deal of Windows games. I run macOS Mojave 10.14.6 on my mid-2019 MacBook Pro (i.e., the last one that shipped with Mojave as the base operating system version) for this very reason. Not everyone can afford the space for partitions or money for altogether different devices. |
|
The primary motivator for us dropping 10.14 support was an effort to modernize and clean up our file handling code by switching over to When looking at dropping an OS, we look at various other factors as well:
We don't make decisions like this lightly. We do make a best effort to support older macOS versions as long as possible (for example, we still support macOS 10.15), but older OSes will be dropped if they get in the way of progress. The last version of Dolphin that supports macOS 10.14 is 5.0-18184. Of course, it won't have all the latest features and improvements. |
This should be all that's required to make the Updater gracefully tell people on < 10.15 to update.
If we can go higher than 10.15, I'd love to know :)
This will unblock std::filesystem stuff