D3D: Restore workaround for erroneous NaN optimization #11603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HLSL compiler incorrectly decides isnan can't be true, so this workaround was originally added in 52c8273 but lost during the conversion to SPIR-V.
This comment was marked as outdated.
This comment was marked as outdated.
iwubcode
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HLSL compiler incorrectly decides isnan can't be true, so this workaround was originally added in 5.0-15109 but was dropped during the conversion to SPIR-V in 5.0-16815. I've readded it and converted it to glsl.
This bug rebroke shadow-eyes.dff on Direct3D 11 and 12 and gave console warnings during shader compilation.