Android: Remove support for the old config system #11641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All settings that we care about from an Android perspective are now supported by the new config system, so we can remove all the Android code for the old config system. This should have no impact on users.
Made unnecessary by the previous commit.
getXGlobal() is now identical to getX(), and setXGlobal(int, X) is now identical to setX(int, X) in the cases where setX(int, X) exists. We can remove/rename them.
No longer used for anything.
JosJuice
force-pushed
the
android-remove-old-config
branch
from
ff7fb9a
to
0833401
Compare
|
Now that I think about it, I think this should fix the issue where we crash when EmulationActivity is recreated after the process was killed. The problem was that we were trying to load the settings before directory initialization finished, but with this PR the call to |
lioncash
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All settings that we care about from an Android perspective are now supported by the new config system, so we can remove all the Android code for the old config system. This should have no impact on users.