RetroAchievements - Achievement Progress Tab

[LillyJadeKatrin]

This is a portion of an integration with the RetroAchievements tools and libraries for connecting to the website, downloading data, unlocking achievements and submitting to leaderboards for games running in Dolphin. In this PR, I add an AchievementsProgressWidget and an AchievementsHeaderWidget to be added to AchievementsWindow, for the player to view data about their current progress and points.

[AdmiralCurtiss]

Whatever you're trying to do in the last commit, it's extremely overcomplicated. Please just do something like this instead:

dolphin/Source/Core/DolphinQt/FIFO/FIFOPlayerWindow.cpp

Lines 49 to 56 in d03e09c

	FifoPlayer::GetInstance().SetFileLoadedCallback(
	[this] { QueueOnObject(this, &FIFOPlayerWindow::OnFIFOLoaded); });
	FifoPlayer::GetInstance().SetFrameWrittenCallback([this] {
	QueueOnObject(this, [this] {
	UpdateInfo();
	UpdateControls();
	});
	});

[AdmiralCurtiss]

This entire thing also feels like full of race conditions. How exactly are you syncing the GUI access with the backend here? Because I'm not seeing anything.

[MayImilae]

So I gave this a try to give it a look, but apparently the progress tab is greyed out if you aren't signed in. Welp, I can't see it on my own. Screenshots please!

[AdmiralCurtiss]

The tab doesn't work when you're logged in either so uuuh

[LillyJadeKatrin]

Oh no, my apologies, I told myself I was going to provide instructions for testing and wound up forgetting by the time I got this far. The progress tab requires you to be logged in and playing a game with achievements, because it's for showing the achievements on the current game, and I have verified locally that at least in the attempts I tried, it does do this.
If you insert the following line at the beginning of AchievementManager::ResolveHash (currently line 427), it will load the achievements for Star Wars: The Clone Wars no matter what game you actually have loaded:
game_hash = {"9445e2aad2843e568229e66eb6cb1a91"};

[AdmiralCurtiss]

The disabled tab is a UX nightmare, tabs just don't do that. Please find a different solution for that one. Otherwise this seems fine enough to me. It's not winning a prize for beauty but whatever.

[LillyJadeKatrin]

The disabled tab is a UX nightmare, tabs just don't do that. Please find a different solution for that one. Otherwise this seems fine enough to me. It's not winning a prize for beauty but whatever.

Not sure I follow what you mean about the disabled tab - what exactly is the problem? Would a good solution allow the player to click the tab but the widget then only shows "must have game loaded" or somesuch?

[AdmiralCurtiss]

Disabled tabs just aren't a thing in any modern UI. As you saw in the opening comments of this PR thread, people will just click on it and be confused why it's not switching to the tab.

Yes, the tab just holding a 'no game loaded' message would be perfectly fine. As would be hiding the tab completely if it contains nothing of value.