Qt: Add float config tooltip slider #11900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
Jun 8, 2023
Source/Core/DolphinQt/Config/ConfigControls/ConfigFloatSlider.h
Outdated
Show resolved
Hide resolved
iwubcode
reviewed
Jun 8, 2023
|
|
||
| // Automatically converts an int slider into a float one. | ||
| // Do not read the int values or ranges directly from it. | ||
| class ConfigFloatSlider : public ToolTipSlider |
There was a problem hiding this comment.
class ConfigFloatSlider final
There was a problem hiding this comment.
The other Config GUI classes aren't final either, though you're right that they probably could be. Maybe open up a separate PR for that?
AdmiralCurtiss
force-pushed
the
add_float_config_tooltip_slider
branch
from
dd2073c
to
03ec86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by:
#11850
This is almost identical to
ConfigSliderthat was already there, though works with floats instead.Screenshot:
