Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file size stats to NAND Check. #12047

Merged
merged 3 commits into from Jul 30, 2023

Conversation

AdmiralCurtiss
Copy link
Contributor

This adds stats to the NAND Check feature that tell you how much of your NAND is used, and if it is overfilled.

nand-okay
nand-full

I'm not 100% happy about the way this is presented, maybe someone has a good idea here. It would also be nice if we had actual options to safely delete stuff in case it's overfull, without having the user manually go to the NAND directory and deleting stuff there..

That way they're available for calculating NAND stats to display to the user. This also adds a few more constants.
Behaves like GetDirectoryStats() but doesn't clamp to the Wii limits, so we can tell the user exactly how overfull their NAND is.
@mbc07
Copy link
Contributor

mbc07 commented Jul 14, 2023

You usually can boot the Wii Menu normally when the NAND is overfilled, and it'll direct you straight to the data management screen, so I'm unsure if adding the ability to delete stuff outside the Wii Menu is worth the effort, but I don't have a strong opinion on this subject...

@AdmiralCurtiss
Copy link
Contributor Author

Well, yes and no. If the NAND is overfilled because of saves or normal channels, yes, you can do that. But if you have somehow managed to put too much data into the part of the NAND that you don't normally have access to (which I'm guessing is what happened here) there isn't really a good way to solve that with official tools -- apparently even a system format doesn't touch some of those files, which kinda makes sense...

Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really my area of expertise but code LGTM. We've had at least one report of a user using this and confirming it helped confirm the problem, so it works as intended.

@JosJuice JosJuice merged commit a912a2c into dolphin-emu:master Jul 30, 2023
11 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the nand-stats-user branch July 30, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants