Skylanders: expand and improve character list #12090
Conversation
Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp
Outdated
Show resolved
Hide resolved
mandar1jn
force-pushed
the
figures-split
branch
from
d04059b
to
5aee216
Compare
Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp
Outdated
Show resolved
Hide resolved
Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp
Outdated
Show resolved
Hide resolved
mandar1jn
force-pushed
the
figures-split
branch
2 times, most recently
from
ccc696a
to
cec30d1
Compare
Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp
Outdated
Show resolved
Hide resolved
Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp
Outdated
Show resolved
Hide resolved
mandar1jn
force-pushed
the
figures-split
branch
from
da62808
to
3aeb30d
Compare
|
Resolved every comment of @deReeperJosh. Some decisions were made on discord in DM's. Happy to elaborate if needed |
mandar1jn
force-pushed
the
figures-split
branch
3 times, most recently
from
5770aae
to
eae3efa
Compare
There was a problem hiding this comment.
Some more review comments from me, might also want to change the width of all the radio buttons/checkboxes to be the same width as each other. As well, maybe change the default size of the window as it looks slightly squashed with the new type radio that has been added:
Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp
Outdated
Show resolved
Hide resolved
Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp
Outdated
Show resolved
Hide resolved
Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp
Outdated
Show resolved
Hide resolved
|
@jnaidu360 seeing as you first worked on this updated window, feel free to add any reviews/thoughts here too :) |
I can replicate the width. Need to figure out why that is different. Literally copy pasted that from the element radio. I can't, however, replicate that extremely cramped look of the options. Windows seems to display those differently. |
|
Might just be a MacOS Qt thing, feel free to ignore the height comment |
|
Okay. I have too little QT experience to fix the width of the filters. I can't get the options to align in the middle |
mandar1jn
force-pushed
the
figures-split
branch
from
25ab680
to
a75c5bb
Compare
The previous list had some issues. A lot of variant id's were set to 0x0000. Althought this works for some figures, on a technicallity implemented into the games, they are technically wrong and don't result in exactly the same experience as the real figures. For example, the previous small fry got a "series 1" text in the summon screen. The real small fry does not have this. I also added figure types so I can add seperate generation logic later. The Kaos element only applies to 3 items. So, I decided to throw it under others since it's not listed as an element in the manual and you can easily search for Kaos
mandar1jn
force-pushed
the
figures-split
branch
from
9ce4aa3
to
31d6aa5
Compare
|
@deReeperJosh every filter should have the same width now. I aligned the radio's to the center. I also fixed your scrollbar issue. There should only be a scrollbar for the figure list on minimum width now |
|
Yup, looks much better now! LGTM |
The previous list had some issues. A lot of variant ids were set to 0x0000. Although this works for some figures, on a technicality implemented into the games, they are technically wrong and don't result in exactly the same experience as the real figures. For example, the previous small fry got a "series 1" text on the summon screen. The real small fry does not have this. I also added figure types so I can add separate generation logic later.
The Kaos element only applies to 3 items. So, I decided to throw it under others since it's not listed as an element in the manual and you can easily search for Kaos
The whole list was regenerated from my personal database of figures. Should contain all figures previously listed and should add some more. For example, legendary sky trophy