Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: add ability to load cube maps into custom texture data #12102

Merged
merged 1 commit into from Sep 3, 2023

Conversation

iwubcode
Copy link
Contributor

Pulled from #11783

Testing would amount to checking texture packs to make sure custom texture support isn't broken. I've checked a few as well as DIT generation.

@iwubcode iwubcode force-pushed the cubemap_custom_texture branch 2 times, most recently from c0e39c7 to 5b5cf12 Compare August 17, 2023 02:03
@iwubcode iwubcode force-pushed the cubemap_custom_texture branch 3 times, most recently from a131bcf to 7f2c597 Compare September 1, 2023 23:19
… our custom texture object. Custom texture object now has the concept of slices in addition to levels. Traditional custom textures have a single slice
Copy link
Contributor

@Dentomologist Dentomologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM and while I don't have a texture pack with cubemaps, loading one without them worked normally.

@JMC47 JMC47 merged commit 900439e into dolphin-emu:master Sep 3, 2023
11 checks passed
@iwubcode iwubcode deleted the cubemap_custom_texture branch September 3, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants