Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: asset load time is now stored as a chrono system_clock time #12103

Merged
merged 1 commit into from Aug 17, 2023

Conversation

iwubcode
Copy link
Contributor

@iwubcode iwubcode commented Aug 13, 2023

This allows me to fabricate times (without creating a file) in a future feature.

Unfortunately, only windows (VS) supports clock_cast which is needed to convert file times to a system clock. I have implemented an approximation for other systems. Users on Linux/Mac/Android would need to test texture packs to make sure this doesn't break existing behavior (in particular the auto reloading which is used for Dynamic Input Textures).

@iwubcode
Copy link
Contributor Author

Just a note for the record. This was tested on Android by @t895 with a texture pack. This was tested by a user in the DIT community on MacOS ARM using a DIT pack (to verify reloading). Not seeing any concerns merging this.

…ime, so that times can be fabricated in a future feature (without creating a file to do so)
@AdmiralCurtiss AdmiralCurtiss merged commit a087920 into dolphin-emu:master Aug 17, 2023
11 checks passed
@iwubcode iwubcode deleted the asset_load_system_time branch August 17, 2023 22:15
@MayImilae
Copy link
Contributor

This PR was mentioned in https://bugs.dolphin-emu.org/issues/13352

@iwubcode
Copy link
Contributor Author

Thanks @MayImilae . TryTwo/Spin2Win reached out to me. The old version of Windows just needs to use the same approach as the other backends that don't currently use clock_cast. I'm not sure offhand how to target just the old windows versions but I imagine it'll be relatively simple. Will open a PR sometime this weekend.

@AdmiralCurtiss
Copy link
Contributor

You'd have to detect the existence of clock_cast at runtime, since we only ship a single Windows build for all Windows platforms. It's probably just easier to disable clock_cast until we drop the older Windows 10 versions...

@iwubcode
Copy link
Contributor Author

Thanks Admiral, that's the same conclusion I came to unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants