Proper Audio/Video Dumping #1220
Conversation
|
Still need to handle starting during emulation. |
|
|
||
| void DumpSamples (const short *buff, int nsamp, int srate); | ||
| void DumpSamplesBE (const short *buff, int nsamp, int srate); | ||
| }; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Still storing duplicate frames when there's no need to. |
| @@ -0,0 +1,62 @@ | |||
| #include <sstream> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Still has a vast majority of coding style issues remaining. Also, please review the usage of static local variables, I think this is extremely error prone as it is right now. |
| u64 tickCountTemp = s_tickCountStart; | ||
| s_tickCountStart = CoreTiming::GetTicks(); | ||
| p.Do(s_tickCountStart); | ||
| s_tickCountStart = tickCountTemp; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@dolphin-emu-bot rebuild |
| #include "VideoCommon/VideoBackendBase.h" | ||
| #include "VideoCommon/VideoConfig.h" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| void* temp_stored_frame = realloc(s_stored_frame, s_bitmap.biSizeImage); | ||
| if (temp_stored_frame) | ||
| { | ||
| s_stored_frame = temp_stored_frame; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Tested and confirmed to work on GC, Wii and Virtual Console games. Video dumping still leaves a lot to be desired in terms of user friendliness, but at least it works now. |
Screwed up the previous PR, replacing with new PR
Old notes: #1183