Netplay: Don't log skippable events as errors #12258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is what we're doing here even allowed by enet? But yeah this makes it a lot more explicit at least. |
This was referenced Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few days ago, I was asked about "unknown event type: 42" errors appearing in the Dolphin log. After investigating, it turned out that these logging calls were added in #11704, without taking into account the Dolphin-specific hack for skipping events relating to traversal and wake-up packets in the main ENet code.
This PR adjusts the logging so that these skipped events are not logged as errors, in case someone asks about this in future. It also gives the 42 constant a name. I put it in ENet.h since that was the lowest common denominator of all the places where it was used.