Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS/KD: Disable download and mail when files are invalid #12266

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

noahpistilli
Copy link
Member

As pointed out by @AdmiralCurtiss in #12184, when the WC24SendList::ReadSendList and/or NWC24Dl::ReadDlList fail, their class member m_data is being used by IOS when called.

This PR fixes it by exiting any function which calls an m_data member which failed to initialize. It also deletes the corrupted file, where either Dolphin or the Wii Menu will regenerate it for later use.

@AdmiralCurtiss
Copy link
Contributor

AdmiralCurtiss commented Nov 3, 2023

Yes, that's a definite improvement. Can you also add a bunch of ASSERT(!IsDisabled()) at the start of every function that attempts to read from or write to m_data?

@AdmiralCurtiss AdmiralCurtiss merged commit 7dae4dd into dolphin-emu:master Nov 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants