Update default IP for HLE BBA #12298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You also need to update StringSetting.kt, for the Android GUI. |
lioncash
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the default IP for the HLE BBA, as the existing IP is apparently no longer in use by schtserv (@schthack please feel free to comment here). The new IP was found here.
For the sake of discussion, alternatively consider populating the default IP with 8.8.8.8, and providing a link to a Wiki from the tooltips or inline descriptions, which would then reference other IPs such as schtserv and sylverant (currently 138.197.20.130 as found here). Maintainers of these servers could then more easily update the Wiki with network etc. changes than having to create a PR to do so in the codebase.
On one hand this approach would be more standardized and balanced, however the current method may be better overall since promoting the most popular server fosters a less fragmented and therefore larger online community as it was with the original server.