Metal: fix crash by enabling concurrent compilation only if available #12311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemenaran
commented
Nov 22, 2023
kemenaran
force-pushed
the
fix-metal-adapter-unknown-selector
branch
from
f5fb12b
to
106f853
Compare
|
PR updated, with:
|
AdmiralCurtiss
force-pushed
the
fix-metal-adapter-unknown-selector
branch
from
106f853
to
1441ca9
Compare
Bug: https://bugs.dolphin-emu.org/issues/13404 On macOS 13.6 / Intel HD 5000, Dolphin crashes with this message: > -[MTLIGAccelDevice setShouldMaximizeConcurrentCompilation:]: unrecognized selector This should be available on all macOS 13.3+ systems – but when using OCLP drivers, some devices use an older version of Metal.framework, which doesn't expose the selector. This concerns Intel Ivy Bridge, Haswell and Nvidia Kepler when using OCLP on macOS 13.3 or newer. (See https://github.com/dortania/OpenCore-Legacy-Patcher/blob/34676702f494a2a789c514cc76dba19b8b7206b1/docs/PATCHEXPLAIN.md?plain=1#L354C1-L354C83) As the behavior is an optional optimization anyway, perform a dynamic detection to avoid crashing if the feature is not available.
AdmiralCurtiss
force-pushed
the
fix-metal-adapter-unknown-selector
branch
from
1441ca9
to
0ecfaf3
Compare
|
Fixed the remaining lint errors. |
ghost
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://bugs.dolphin-emu.org/issues/13404
On macOS 13.6 / Intel Iris with Metal 2, when starting any game, Dolphin crashes immediately with this message:
It seems that even on macOS 13.3+, not all devices implement this selector (first implemented in #11911).
As the behavior is an optional optimization anyway, we now perform a dynamic detection to avoid crashing if the feature is not available.