Android: Fix issue when launching a game when Dolphin is not open #12345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for figuring out the cause of this issue. This PR as it's currently written would have undesired behavior when launching games from Dolphin's game list. Could you make |
|
Updated the PR include a check if it's being launched from an intent and will finish it if is. |
|
If |
|
Good catch. Moved the logic into the |
|
Looks good to me, but please squash your commits into one. |
Add frontIntent flag to control activity.finish() Moved parent activity finish inside of performLaunchChecks
minhaferzz
force-pushed
the
startup-handler
branch
from
c5933ea
to
4b91bf4
Compare
|
Done |
JosJuice
approved these changes
Dec 1, 2023
lioncash
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When Dolphin is not open, attempting to launch a game from a frontend launcher will result in the user opening Dolphin and being taken back to the frontend launcher.
Why
This is caused by calling
parent.finish()beforeAfterDirectoryInitializationRunneris complete, thus canceling the launch of the game.How
Fixed by calling
activity.finish()afterAfterDirectoryInitializationRunneris initialized and complete.