Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Resolve lingering -Wshadow warnings #12405

Merged
merged 4 commits into from Dec 12, 2023
Merged

General: Resolve lingering -Wshadow warnings #12405

merged 4 commits into from Dec 12, 2023

Commits on Dec 12, 2023

  1. LightingShaderGen: Resolve -Wshadow warnings 

    Given how the lambda doesn't capture anything, we can move this to a
internally linked function, which prevents any name shadowing.
    @lioncash
    lioncash committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a812a1f View commit details
    Browse the repository at this point in the history

  2. HLE_OS: Resolve -Wshadow warnings 

    We get a warning about shadowing the va_list type and just
run-of-the-mill variable shadowing, which we can easily fix.
    @lioncash
    lioncash committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    81d5370 View commit details
    Browse the repository at this point in the history

  3. WC24PatchEngine: Resolve -Wshadow warning 

    While not captured, we're definitely shadowing the result variable
outside the lambda.
    @lioncash
    lioncash committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    79c84c9 View commit details
    Browse the repository at this point in the history

  4. ConfigFloatSlider: Resolve -Wshadow warning 

    Fairly straightforward variable shadowing.
    @lioncash
    lioncash committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e883bbc View commit details
    Browse the repository at this point in the history