Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JitArm64: Use 64-bit register for address in mtsrin #12429

Merged
merged 1 commit into from Dec 17, 2023

Conversation

JosJuice
Copy link
Member

Fixes a regression from PR #12124 that, depending on the host memory layout, could cause either a host crash or a guest crash when running F-Zero GX.

Fixes a regression from d34d3bd that, depending on the host memory
layout, could cause either a host crash or a guest crash when running
F-Zero GX.
@dolphin-ci
Copy link

dolphin-ci bot commented Dec 16, 2023

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • smg-marioeyes on mvk-osx-m1: diff
  • sms-coconut-drinks on mvk-osx-m1: diff
  • DKCR-Char on mtl-osx-m1: diff
  • DKCR-fast-depth on mtl-osx-m1: diff
  • fishing-resort-map on mtl-osx-m1: diff
  • major-minor on mtl-osx-m1: failed to render
  • mario-golf-oob on mtl-osx-m1: failed to render
  • metroid-visor on mtl-osx-m1: diff
  • mii-channel on mtl-osx-m1: diff

automated-fifoci-reporter

@dvessel
Copy link
Contributor

dvessel commented Dec 17, 2023

Thanks for the quick fix. It’s no longer crashing.

@lioncash lioncash merged commit 5192349 into dolphin-emu:master Dec 17, 2023
11 checks passed
@JosJuice JosJuice deleted the jitarm64-mtsrin-64-bit branch December 17, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants