JitArm64: Call rlwinmx implementation from rlwnmx with imm b #12431
Conversation
This way we get some additional optimized cases for rlwnmx with imm b.
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
| @@ -182,6 +182,8 @@ class JitArm64 : public JitBase, public Arm64Gen::ARM64CodeBlock, public CommonA | |||
|
|
|||
| bool IsFPRStoreSafe(size_t guest_reg) const; | |||
|
|
|||
| void rlwinmx_internal(UGeckoInstruction inst, u32 sh); | |||
There was a problem hiding this comment.
Is this intended to be public?
There was a problem hiding this comment.
Well, I guess it has no real reason to be public... All these other helper methods already were, though. What do you think, should I move this one to private?
There was a problem hiding this comment.
tbh, the other respective helpers should also reasonably be private if they have no need to be public. I'm fine merging as is, if you'd prefer to do that as it's own thing. It's not really a hard blocker or anything.
There was a problem hiding this comment.
Yeah, I think I'll do that in a separate PR then.
This way we get some additional optimized cases for rlwnmx with imm b.