Core/Debugger_SymbolMap: Minor interface cleanup #12444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is wholly unused in current code.
…rface The CPU thread guard already allows access to the system instance. We can remove the system parameter to reduce rendundancy here.
This also allows the constructed CallstackEntry instances to be moved into the output vector, rather than being copied.
JosJuice
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to pass in both a reference to a System instance and a CPUThreadGuard instance at the same time. We can just pass in the the cpu thread guard and retrieve the system instance from it.
Also removes an unused function and makes GetCallstack() a little nicer by moving callstack entries into the output vector instead of churning copies.