PowerPC: Add access size parameter to MMU::IsOptimizableRAMAddress #12489
Conversation
|
Sorry for the potential dumb question but does this have any implications on specific software or is it just a safety thing? |
| @@ -930,8 +930,10 @@ bool MMU::IsOptimizableRAMAddress(const u32 address) const | |||
| // | |||
| // We store whether an access can be optimized to an unchecked access | |||
| // in dbat_table. | |||
| u32 bat_result = m_dbat_table[address >> BAT_INDEX_SHIFT]; | |||
| return (bat_result & BAT_PHYSICAL_BIT) != 0; | |||
| const u32 last_byte_address = address + (access_size >> 3) - 1; | |||
There was a problem hiding this comment.
There's a TODO a few lines up that you can remove now.
There was a problem hiding this comment.
Also is this even correct? Why the bitshift by 3?
There was a problem hiding this comment.
Oh is the size given in bits, not bytes? In that case yeah that makes sense then.
There was a problem hiding this comment.
There's a TODO a few lines up that you can remove now.
Oops, yes.
Oh is the size given in bits, not bytes? In that case yeah that makes sense then.
Yeah, it's in bits, following the pattern used by IsOptimizableMMIOAccess.
Just for safety. No software is known to be affected. |
For correctness, we need to check not only the start address of the memory access but also the end address.
JosJuice
force-pushed
the
optimizable-access-size
branch
from
845bdb2
to
b972329
Compare
For correctness, we need to check not only the start address of the memory access but also the end address.