Core/Movie: Refactor to class, move to System. #12502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
globals-movie
branch
4 times, most recently
from
70328fd
to
81e270d
Compare
JosJuice
reviewed
Jan 14, 2024
A bit of global state remains (the `header` in `BeginRecordingInput()`) due to unclear lifetime requirements.
AdmiralCurtiss
force-pushed
the
globals-movie
branch
from
81e270d
to
95cba6b
Compare
lioncash
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of global state remains (the
headerinBeginRecordingInput()) due to unclear lifetime requirements.There's some really ugly stuff in here that definitely needs to be refactored at some point. The MD5 threads are just detached into the void (so in theory if the System was deallocated before the thread was done calculating the MD5 it would write to stale pointers...),
mbedtls_md_file()probably doesn't do the right thing for Unicode filenames on Windows (or anything sensible for non-ISO input files, for that matter), the disc change storage method is very limiting for no good reason except I guess it had to fit into a predefined header somehow, it's extremely unclear what anything is initialized to (wouldn't surprise me if some state survives into the next movie if you record multiple within a session...), and that's just the obvious ones I noticed.