Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPCAnalyst: Merge duplicate expression in ReorderInstructionsCore() #12522

Merged
merged 1 commit into from Jan 26, 2024

Conversation

lioncash
Copy link
Member

@lioncash lioncash commented Jan 23, 2024

The type checking is duplicated here, which makes this seem a little weird, so we can get rid of it.

The type checking is duplicated here, which makes this seem a little
weird, so we can get rid of it.
@JosJuice
Copy link
Member

Seems like this odd code comes from 40e0dd9. IIRC, it was my intent with that commit to expand ReorderType::CMP to work with all instructions that write to crOut and aren't disqualified by any other checks, getting rid of the isCmp function. But now that I think about it, does this counteract the instruction swapping done by ReorderType::CROR...?

@JosJuice
Copy link
Member

Ah, it's actually fine, because the CROR reordering happens after the CMP reordering. I trust my past self then. LGTM.

@AdmiralCurtiss AdmiralCurtiss merged commit e740e32 into dolphin-emu:master Jan 26, 2024
11 checks passed
@lioncash lioncash deleted the ppcanalyst branch January 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants