Core: Convert some preprocessor checking to use #ifdef/#if defined() over #if #12525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was treating the identifier as if it were always defined by default
This is only defined on certain platforms and isn't always defined.
\#if assumes the symbols will always be defined, but they aren't depending on the platform.
This way we don't assume these symbols are always defined.
JosJuice
approved these changes
Jan 23, 2024
BhaaLseN
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few cases, we were assuming certain definitions would exist, but e.g.
__APPLE__wouldn't be defined by default on Windows.This isn't a huge deal (the most that would happen is some warning/output spam), but we can just convert them over to make it nicer.