Add host URL setting to achievements config #12531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Jan 24, 2024
The Host URL setting in the RetroAchievements config will, if set, be used as the host URL for all server requests for achievements. This allows for an easy switch to the RetroAchievements staging server for testing.
LillyJadeKatrin
force-pushed
the
retroachievements-bugfix
branch
from
a9e068c
to
03e3f65
Compare
BhaaLseN
reviewed
Jan 24, 2024
| @@ -38,6 +38,9 @@ void AchievementManager::Init() | |||
| { | |||
| if (!m_is_runtime_initialized && Config::Get(Config::RA_ENABLED)) | |||
| { | |||
| std::string host_url = Config::Get(Config::RA_HOST_URL); | |||
| if (!host_url.empty()) | |||
| rc_api_set_host(host_url.c_str()); | |||
There was a problem hiding this comment.
Just wondering, does this properly handle cases where the entered URL is not a valid achievement endpoint (or otherwise unavailable/unaccessible)?
There was a problem hiding this comment.
You'll get an error in the logger and otherwise it will function basically identically to just not having a connection at all.
lioncash
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Host URL setting in the RetroAchievements config will, if set, be used as the host URL for all server requests for achievements. This allows for an easy switch to the RetroAchievements staging server for testing.