Add Missing EncodeRegTo64 in JitArm64::dcbx #12540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I from what I can tell,
ARM64FloatEmitter::ABI_PushRegisters
expects an XReg temporary, not a WReg. Otherwise, it may emit code with incongruent usage of WRegs then XRegs:This causes a segmentation fault. While I have never witnessed this happening from the usage in
JitArm64::dcbx
, it's better in principle to fix it. This error mislead me in my own usage ofARM64FloatEmitter::ABI_PushRegisters
. It may be worth adding a runtime assertion inARM64FloatEmitter::ABI_PushRegisters
to enforce this.