Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeWidget: Simplify Case-Insensitive Contains #12598

Merged
merged 1 commit into from Feb 28, 2024
Merged

CodeWidget: Simplify Case-Insensitive Contains #12598

merged 1 commit into from Feb 28, 2024

Conversation

mitaclaw
Copy link
Contributor

@mitaclaw mitaclaw commented Feb 27, 2024 •
edited

This seems to be the more modern way of doing case-insensitive QString comparisons. It's probably faster, too.

lioncash
lioncash approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@lioncash lioncash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way nicer than churning strings

@lioncash lioncash merged commit 5a81916 into dolphin-emu:master Feb 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@mitaclaw @lioncash