Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: Prefer D3D11/12 over OpenGL on Windows. #12641

Merged
merged 1 commit into from Mar 20, 2024

Conversation

jordan-woyak
Copy link
Member

Modern hardware has better performance with D3D.
Outdated hardware has better compatibility with D3D.

Uninformed Windows uses are leaving performance and compatibility on the table with OpenGL defaults.

@AdmiralCurtiss
Copy link
Contributor

I think this is a reasonable change, anyone have anything against this?

@Tilka Tilka requested a review from degasus March 18, 2024 01:15
Copy link
Member

@degasus degasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about the order of D3D11 vs D3D12, but it makes sense to place OpenGL after them. The decision to set OpanGL at the top is roughly 10 years old and outdated.

@MayImilae
Copy link
Contributor

MayImilae commented Mar 18, 2024

OpenGL was last updated in 2017 with 4.6. Modern hardware isn't going to target or focus on an API that isn't getting any updates, so OpenGL is going to get progressively worse over time. So I'm fine with demoting OpenGL from default at this stage.

Vulkan might be nicer as a global default, since it is basically our backbone graphics backend as it is the only one that's on all platforms that we support. How is Vulkan performance across modern Intel/AMD/Nvidia GPUs?

@jordan-woyak
Copy link
Member Author

Intel integrated graphics is still in the wild that will not work with Vulkan or D3D12 at all, and can be questionable with OpenGL.

Vulkan might be better on some systems, and D3D12 might be better on some systems, but I think D3D11 is going to give almost every Windows user a satisfactory default experience.

@mbc07
Copy link
Contributor

mbc07 commented Mar 18, 2024

Also, some old Intel iGPUs on Windows (from 3rd to 5th gen CPUs) can only render "properly" with D3D11, being completely broken with our other backends even when the driver claims support for the other APIs...

@jordan-woyak jordan-woyak merged commit 76a74da into dolphin-emu:master Mar 20, 2024
11 checks passed
@jordan-woyak jordan-woyak deleted the d3d-before-ogl branch March 20, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants