Common: add even more json utility functions #12652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
json_util_update
branch
2 times, most recently
from
6e3a933
to
7fb2d21
Compare
iwubcode
changed the title
…ve it return an optional, this provides the caller with more flexibility
…FromJson' to match 'ReadNumericFromJson' functionality for other data types, similarly support other data types for 'ToJsonArray'
iwubcode
force-pushed
the
json_util_update
branch
from
7fb2d21
to
146504d
Compare
jordan-woyak
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more utility functions to help with writing
picojsonlogic.ReadStringFromJsonandReadBoolFromJsonwere added to match the existing numeric capability. They all now return aoptionalas that was more flexible than passing in the default.Similarly, I updated
ToJsonArrayto support any array type that the json library natively supports (strings or bools).