PPCSymbolDB: GetDescription by std::string_view #12704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should save a lot of deep copies.
mitaclaw
force-pushed
the
symbol-description-view
branch
from
bde7d0a
to
672be6a
Compare
iwubcode
reviewed
Apr 13, 2024
| @@ -108,13 +108,11 @@ Common::Symbol* PPCSymbolDB::GetSymbolFromAddr(u32 addr) | |||
| return nullptr; | |||
| } | |||
|
|
|||
| std::string PPCSymbolDB::GetDescription(u32 addr) | |||
| std::string_view PPCSymbolDB::GetDescription(u32 addr) | |||
There was a problem hiding this comment.
Would be nice if this was const too (and GetSymbolFromAddr)
There was a problem hiding this comment.
Yep, PPCSymbolDB and its base class, Common::SymbolDB, lack a lot of const-correctness as technical debt from them being global variables for so many years. I can turn this PR into a general "PPCSymbolDB updates" PR if that's desired, I just saw this as a quick and simple fix to get approved fast.
There was a problem hiding this comment.
Nah, can be saved for another day. Code as is looks good. Thanks @mitaclaw
iwubcode
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should save a lot of deep copies.