Remove rounded corners on emulation render window #12743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filoppi
force-pushed
the
remove-round-corners-on-game-window
branch
from
089cc6a
to
a816915
Compare
|
Can you post a before/after screenshot? |
On Windows 11, when playing windowed in a separate window/widget from the main emulator window, we don't want the window to have rounded corners, as it prevents the corner pixels from being visible
Filoppi
force-pushed
the
remove-round-corners-on-game-window
branch
from
a816915
to
9106704
Compare
|
Does this cause any issues on Windows versions before 11? Or do they just silently ignore the flag? |
|
The flag is just ignored |
|
I am extremely happy with this. I wish we could do the same on macOS! |
iwubcode
approved these changes
Apr 28, 2024
jordan-woyak
approved these changes
Apr 28, 2024
|
For progress report reasons, please hold off merging this until the report goes up in roughly 36 hours from this comment. I absolutely want that in the next report and launching now would make versioning the beta messier. Progress Report is done and we're in the clear! |
MayImilae
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows 11, when playing windowed in a separate window/widget from the main emulator window, we don't want the window to have rounded corners, as it prevents the corner pixels from being visible
Here's how it would look, there's not much to it:
