Common: add Json helper utilities for loading or saving to a file #12818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use a static_cast. As discussed, a Saturating cast doesn't make sense when converting a double to a float
iwubcode
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing this enough in a branch that I figured I should probably make some functions out of it. And hey, it turns out it can clean up a bit of our code in master too!
I tested all areas impacted: DiT, texture loading, and graphics mods.
(also JsonUtil.cpp wasn't added to the source file, which triggered the
SaturatingCasterror, so that was fixed based on our previous discussion)