Android: Implement OpenSLESStream::SetRunning #12833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbc07
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Just tested this on a Galaxy S23, in the following scenarios:
- Entering/exiting the recent apps screen while emulation is running
- Locking/unlocking the phone screen while emulation is running
- Pausing/resuming emulation from the overlay menu from the emulation activity
Audio properly paused/resumed in all cases. In fact, compared to master, where I can hear a very, very little amount of white noise in those scenarios (if I set the phone volume to the maximum and put the speaker grill close to my ear), in this PR the audio is completely muted, and the speakers become dead silent.
It's an improvement, and LGTM.
|
Tested it, and it seems to work perfectly fine as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.