Scale challenge icons based on screen height

[LillyJadeKatrin]

No description provided.

[JosJuice]

This will be shown next to text, right? If so, you should use DisplayFramebufferScale so you get the same scale factor as for text.

(Or is imgui already scaling image sizes by this? Is this change being done for another reason than HiDPI support?)

[LillyJadeKatrin]

The change is actually kinda the opposite of HiDPI; there were complaints that at smaller screen sizes the icons were taking up too much space. Looked up what That Other Emulator Platform does and for 64x64 icons (same ones as here) they were scaled to 1/16 of the window height, which at 1024 is full size, hence the calculation I perform here.

[iwubcode]

I appreciate you bringing that up Jos. I questioned it too but forgot to post about it. We do already scale for hidpi (just to mention).

It feels a bit strange to me to scale just the icons. I'd almost prefer if we came up with what visual look we want the UI to have at our max resolution (or some specific resolution) and then if users still want to scale, we could have a general purpose scale element that increases or decreases the UI size to user taste.

But at the same time, I don't want to block this over something so silly. If this needs to get pushed, we can figure things out later.

[JosJuice]

It's fine I guess.