Dolphin debugger enhancements #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skidau
force-pushed
the
debugger-step-out
branch
2 times, most recently
from
5f2a5ec
to
77faf50
Compare
| { | ||
| if (CCPU::IsStepping()) | ||
| { | ||
| PowerPC::breakpoints.Add(LR, true); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
skidau
force-pushed
the
debugger-step-out
branch
from
77faf50
to
db73ea1
Compare
|
@zhuowei I have replaced the step out function with a more robust version which uses single stepping. |
skidau
force-pushed
the
debugger-step-out
branch
2 times, most recently
from
9a650d2
to
f90fb61
Compare
| { | ||
| u32 addr = GetWatchAddr(row); | ||
| if (Memory::IsRAMAddress(addr)) | ||
| return wxString::Format("%s", Memory::GetString(addr, 32)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
skidau
force-pushed
the
debugger-step-out
branch
from
f90fb61
to
dededec
Compare
|
Thanks, Lioncash. I have made changes to cover the review comments. |
skidau
force-pushed
the
debugger-step-out
branch
from
dededec
to
1d71676
Compare
skidau
changed the title
| long style = wxTAB_TRAVERSAL | wxBORDER_NONE, | ||
| CCodeWindow(const SCoreStartupParameter& _LocalCoreStartupParameter, | ||
| CFrame * parent, | ||
| wxWindowID id = wxID_ANY, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
skidau
force-pushed
the
debugger-step-out
branch
from
e2511e2
to
3243f39
Compare
| void OnPopupMenu(wxCommandEvent& event); | ||
|
|
||
| private: | ||
| u32 addr = 0; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
skidau
force-pushed
the
debugger-step-out
branch
3 times, most recently
from
19f7456
to
f3b586b
Compare
Made the floating windows toolbars dockable. Scaled down the breakpoint toolbar icons to 16x16.
Saved Breakpoints and watches per game in the game ini.
…invalid accesses on Wii games in DEBUGFAST builds
| { | ||
| u32 addr = GetWatchAddr(row); | ||
| if (Memory::IsRAMAddress(addr)) | ||
| return Memory::GetString(addr, 32).c_str(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Fixed watch labels from being truncated at the first whitespace.
skidau
force-pushed
the
debugger-step-out
branch
from
798b520
to
73dca1c
Compare
…a watch name. Code style updates.
…hile the debugger is stepping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a "Step Out" (aka "Step return") function to the debugger.
Added a RAM watch window to the debugger.
Fixed a bug when stepping in JIT mode (where there was a breakpoint at the instruction being stepped).
@zhuowei might be interested in this.